Messages in this thread | | | From | Linus Torvalds <> | Date | Wed, 9 Dec 2020 11:17:56 -0800 | Subject | Re: [GIT PULL] IOMMU fix for 5.10 (-final) |
| |
On Wed, Dec 9, 2020 at 11:12 AM Jerry Snitselaar <jsnitsel@redhat.com> wrote: > > Since the field in the device table entry format expects it to be n > where there are 2^n entries in the table I guess it should be: > > #define DTE_IRQ_TABLE_LEN 9 > #define MAX_IRQS_PER_TABLE (1 << DTE_IRQ_TABLE_LEN)
No, that "DTE_IRQ_TABLE_LEN" is not the size shift - it's the size shift value in that DTE field, which is shifted up by 1.
That's why the current code does that
#define DTE_IRQ_TABLE_LEN (9ULL << 1)
there..
Which was why I suggested that new #define that is the *actual* shift value, and then the DTE thing and the MAX_IRQS_PER_TABLE values would depend on that.
Linus
| |