Messages in this thread | | | From | Anton Altaparmakov <> | Subject | Re: [PATCH -next] fs/ntfs: fix set but not used variable 'log_page_mask' | Date | Thu, 10 Dec 2020 02:51:17 +0000 |
| |
Hi Andrew,
Ah, oops! Thank you and apologies. Quite right the alternative patch was even better. No need to apply this patch after all...
Zheng, the log_page_mask variable was removed altogether so your patch no longer makes sense.
Best regards,
Anton
> On 10 Dec 2020, at 02:36, Andrew Morton <akpm@linux-foundation.org> wrote: > > On Tue, 8 Dec 2020 08:24:02 +0000 Anton Altaparmakov <anton@tuxera.com> wrote: > >> Can you please apply this? >> >> ... >> >>> --- a/fs/ntfs/logfile.c >>> +++ b/fs/ntfs/logfile.c >>> @@ -507,7 +507,7 @@ bool ntfs_check_logfile(struct inode *log_vi, RESTART_PAGE_HEADER **rp) >>> * optimize log_page_size and log_page_bits into constants. >>> */ >>> log_page_bits = ntfs_ffs(log_page_size) - 1; >>> - size &= ~(s64)(log_page_size - 1); >>> + size &= ~(s64)(log_page_mask); >>> /* >>> * Ensure the log file is big enough to store at least the two restart >>> * pages and the minimum number of log record pages. > > https://lore.kernel.org/lkml/1604821092-54631-1-git-send-email-alex.shi@linux.alibaba.com/ > addressed this? >
-- Anton Altaparmakov <anton at tuxera.com> (replace at with @) Lead in File System Development, Tuxera Inc., http://www.tuxera.com/ Linux NTFS maintainer
| |