lkml.org 
[lkml]   [2020]   [Dec]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 1/4] spmi: get rid of a warning when built with W=1
    Date
    From: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>

    The SPMI core complaing with this warning when built with W=1:

    drivers/spmi/spmi.c: In function ‘spmi_controller_remove’:
    drivers/spmi/spmi.c:548:6: warning: variable ‘dummy’ set but not used [-Wunused-but-set-variable]
    548 | int dummy;
    | ^~~~~

    As the dummy var isn't needed, remove it.

    Reviewed-by: Stephen Boyd <sboyd@kernel.org>
    Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
    Link: https://lore.kernel.org/r/aacfd03835b7d1b3b6c21665b44000fe7242e535.1601360391.git.mchehab+huawei@kernel.org
    Signed-off-by: Stephen Boyd <sboyd@kernel.org>
    ---
    drivers/spmi/spmi.c | 5 +----
    1 file changed, 1 insertion(+), 4 deletions(-)

    diff --git a/drivers/spmi/spmi.c b/drivers/spmi/spmi.c
    index c16b60f645a4..fd3ff6079b15 100644
    --- a/drivers/spmi/spmi.c
    +++ b/drivers/spmi/spmi.c
    @@ -545,13 +545,10 @@ static int spmi_ctrl_remove_device(struct device *dev, void *data)
    */
    void spmi_controller_remove(struct spmi_controller *ctrl)
    {
    - int dummy;
    -
    if (!ctrl)
    return;

    - dummy = device_for_each_child(&ctrl->dev, NULL,
    - spmi_ctrl_remove_device);
    + device_for_each_child(&ctrl->dev, NULL, spmi_ctrl_remove_device);
    device_del(&ctrl->dev);
    }
    EXPORT_SYMBOL_GPL(spmi_controller_remove);
    --
    https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git/
    https://git.kernel.org/pub/scm/linux/kernel/git/sboyd/spmi.git
    \
     
     \ /
      Last update: 2020-12-10 03:37    [W:6.969 / U:0.136 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site