lkml.org 
[lkml]   [2020]   [Dec]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRE: [PATCH net-next 1/1] net: stmmac: allow stmmac to probe for C45 PHY devices
    Date


    > -----Original Message-----
    > From: Andrew Lunn <andrew@lunn.ch>
    > Sent: Thursday, December 10, 2020 12:09 AM
    > To: Wong, Vee Khee <vee.khee.wong@intel.com>
    > Cc: Giuseppe Cavallaro <peppe.cavallaro@st.com>; Alexandre Torgue
    > <alexandre.torgue@st.com>; Jose Abreu <joabreu@synopsys.com>; David
    > S . Miller <davem@davemloft.net>; Jakub Kicinski <kuba@kernel.org>;
    > Maxime Coquelin <mcoquelin.stm32@gmail.com>; Voon, Weifeng
    > <weifeng.voon@intel.com>; netdev@vger.kernel.org; linux-
    > kernel@vger.kernel.org; Ong, Boon Leong <boon.leong.ong@intel.com>;
    > linux-stm32@st-md-mailman.stormreply.com; linux-arm-
    > kernel@lists.infradead.org
    > Subject: Re: [PATCH net-next 1/1] net: stmmac: allow stmmac to probe for
    > C45 PHY devices
    >
    > On Wed, Dec 09, 2020 at 07:19:33PM +0800, Wong Vee Khee wrote:
    > > Assign stmmac's mdio_bus probe capabilities to MDIOBUS_C22_C45.
    > > This extends the probing of C45 PHY devices on the MDIO bus.
    > >
    > > Signed-off-by: Wong Vee Khee <vee.khee.wong@intel.com>
    > > ---
    > > drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c | 1 +
    > > 1 file changed, 1 insertion(+)
    > >
    > > diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c
    > b/drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c
    > > index b2a707e2ef43..9f96bb7d27db 100644
    > > --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c
    > > +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c
    > > @@ -364,6 +364,7 @@ int stmmac_mdio_register(struct net_device *ndev)
    > > memcpy(new_bus->irq, mdio_bus_data->irqs,
    > sizeof(new_bus->irq));
    > >
    > > new_bus->name = "stmmac";
    > > + new_bus->probe_capabilities = MDIOBUS_C22_C45;
    >
    > It looks like this needs to be conditional on the version. xgmax2
    > supports C45. And gmac4. But other versions don't.
    >
    > Andrew

    I will send a v2 with conditional checking for gmac4.
    I do not have a xgmac2 hardware setup to test this.

    \
     
     \ /
      Last update: 2020-12-09 23:40    [W:3.453 / U:0.028 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site