lkml.org 
[lkml]   [2020]   [Dec]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH -next] net/mlx5_core: remove unused including <generated/utsrelease.h>
    On Wed, Dec 09, 2020 at 09:04:46AM -0800, Jakub Kicinski wrote:
    > On Wed, 9 Dec 2020 08:21:00 +0200 Leon Romanovsky wrote:
    > > On Tue, Dec 08, 2020 at 11:22:26AM -0800, Jakub Kicinski wrote:
    > > > On Mon, 7 Dec 2020 20:14:00 +0800 Zou Wei wrote:
    > > > > Remove including <generated/utsrelease.h> that don't need it.
    > > > >
    > > > > Signed-off-by: Zou Wei <zou_wei@huawei.com>
    > > > > drivers/net/ethernet/mellanox/mlx5/core/en_rep.c | 1 -
    > > > > 1 file changed, 1 deletion(-)
    > > > >
    > > > > diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_rep.c b/drivers/net/ethernet/mellanox/mlx5/core/en_rep.c
    > > > > index 989c70c..82ecc161 100644
    > > > > +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_rep.c
    > > > > @@ -30,7 +30,6 @@
    > > > > * SOFTWARE.
    > > > > */
    > > > >
    > > > > -#include <generated/utsrelease.h>
    > > > > #include <linux/mlx5/fs.h>
    > > > > #include <net/switchdev.h>
    > > > > #include <net/pkt_cls.h>
    > >
    > > Jakub,
    > >
    > > You probably doesn't have latest net-next.
    > >
    > > In the commit 17a7612b99e6 ("net/mlx5_core: Clean driver version and
    > > name"), I removed "strlcpy(drvinfo->version, UTS_RELEASE,
    > > sizeof(drvinfo->version));" line.
    > >
    > > The patch is ok, but should have Fixes line.
    > > Fixes: 17a7612b99e6 ("net/mlx5_core: Clean driver version and name")
    >
    > Hm. Pretty sure our build bot gets a fresh copy before testing.
    > Must had been some timing issue, perhaps? Looks like the commit
    > came in with the auxbus merge.

    mlx5-next is in linux-next independently so people will be sending
    fixes against stuff in linux-next before it hits net-next.

    Jason

    \
     
     \ /
      Last update: 2020-12-09 22:03    [W:5.961 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site