Messages in this thread | | | From | Rob Herring <> | Date | Tue, 8 Dec 2020 13:30:35 -0600 | Subject | Re: [PATCH v2 1/3] reset: hisilicon: correct vendor prefix |
| |
On Mon, Dec 7, 2020 at 8:16 PM Leizhen (ThunderTown) <thunder.leizhen@huawei.com> wrote: > > > > On 2020/12/8 7:08, Rob Herring wrote: > > On Fri, Dec 04, 2020 at 09:42:34AM +0800, Zhen Lei wrote: > >> The vendor prefix of "Hisilicon Limited" is "hisilicon", it is clearly > >> stated in "vendor-prefixes.yaml". > > > > Yes, but you can't fix this as changing it breaks compability between > > DTBs and kernels. > > > > hisi has to be documented and marked 'deprecated'. > > I searched, and this is the only place that uses the hisi prefix. Currently, > YAML check will report warnings due to mismatch any of the regexes defined > in Documentation/devicetree/bindings/vendor-prefixes.yaml > > Is it not good to add hisi prefix to clear warnings? > "^hisi,.*": > description: Hisilicon Limited, deprecated. > > > By the way, Hi Rob: > The license information in some YAML files is incorrect. Can you correct it in v5.11? > For example: > WARNING: DT binding documents should be licensed (GPL-2.0-only OR BSD-2-Clause) > #26: FILE: Documentation/devicetree/bindings/thermal/allwinner,sun8i-a83t-ths.yaml:1: > +# SPDX-License-Identifier: GPL-2.0
No, I can't change them. I'm not the copyright holder. The ones that are not dual licensed are most likely converted from the old text bindings which were default GPL2.
Rob
| |