Messages in this thread | | | Subject | Re: [PATCH v3 2/5] tracing: Rework synthetic event command parsing | From | Tom Zanussi <> | Date | Tue, 08 Dec 2020 11:37:02 -0600 |
| |
Hi Steve,
On Mon, 2020-12-07 at 19:16 -0500, Steven Rostedt wrote: > On Mon, 26 Oct 2020 10:06:10 -0500 > Tom Zanussi <zanussi@kernel.org> wrote: > > > Now that command parsing has been delegated to the create functions > > and we're no longer constrained by argv_split(), we can modify the > > synthetic event command parser to better match the higher-level > > structure of the synthetic event commands, which is basically an > > event > > name followed by a set of semicolon-separated fields. > > > > Since we're also now passed the raw command, we can also save it > > directly and can get rid of save_cmdstr(). > > > > Signed-off-by: Tom Zanussi <zanussi@kernel.org> > > --- > > > > This patch fails to build with: > > CC kernel/trace/trace_events_synth.o > /work/git/linux-trace.git/kernel/trace/trace_events_synth.c: In > function ‘create_or_delete_synth_event’: > /work/git/linux-trace.git/kernel/trace/trace_events_synth.c:1372:8: > error: implicit declaration of function ‘check_command’ [- > Werror=implicit-function-declaration] > 1372 | ret = check_command(raw_command); > | ^~~~~~~~~~~~~ > cc1: some warnings being treated as errors > make[3]: *** [/work/git/linux-trace.git/scripts/Makefile.build:283: > kernel/trace/trace_events_synth.o] Error 1 > make[2]: *** [/work/git/linux-trace.git/scripts/Makefile.build:500: > kernel/trace] Error 2 > make[1]: *** [/work/git/linux-trace.git/Makefile:1799: kernel] Error > 2 > make[1]: Leaving directory '/work/git/nobackup/bxtest/trace' > make: *** [Makefile:185: __sub-make] Error 2 >
Oops, yeah, a stray check_command() call got left behind in that patch when refactoring, should be moved to the next patch.
Tom
> -- Steve
| |