Messages in this thread | | | From | "Pandruvada, Srinivas" <> | Subject | Re: [PATCH -next] platform/x86: ISST: Mark mmio_range_devid_0 and mmio_range_devid_1 with static keyword | Date | Tue, 8 Dec 2020 15:22:04 +0000 |
| |
On Tue, 2020-12-08 at 20:28 +0800, Zou Wei wrote: > Fix the following sparse warnings: > > drivers/platform/x86/intel_speed_select_if/isst_if_mmio.c:23:24: > warning: symbol 'mmio_range_devid_0' was not declared. Should it be > static? > drivers/platform/x86/intel_speed_select_if/isst_if_mmio.c:28:24: > warning: symbol 'mmio_range_devid_1' was not declared. Should it be > static? > Yesterday I sent a patch "[PATCH v2 2/3] platform/x86: ISST: Allow configurable offset range" to fix.
Thanks, Srinivas
> Signed-off-by: Zou Wei <zou_wei@huawei.com> > --- > drivers/platform/x86/intel_speed_select_if/isst_if_mmio.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git > a/drivers/platform/x86/intel_speed_select_if/isst_if_mmio.c > b/drivers/platform/x86/intel_speed_select_if/isst_if_mmio.c > index 2906cfe..ff49025 100644 > --- a/drivers/platform/x86/intel_speed_select_if/isst_if_mmio.c > +++ b/drivers/platform/x86/intel_speed_select_if/isst_if_mmio.c > @@ -20,12 +20,12 @@ struct isst_mmio_range { > int end; > }; > > -struct isst_mmio_range mmio_range_devid_0[] = { > +static struct isst_mmio_range mmio_range_devid_0[] = { > {0x04, 0x14}, > {0x20, 0xD0}, > }; > > -struct isst_mmio_range mmio_range_devid_1[] = { > +static struct isst_mmio_range mmio_range_devid_1[] = { > {0x04, 0x14}, > {0x20, 0x11C}, > };
| |