Messages in this thread | | | Subject | Re: [PATCH 2/7] net: batman-adv: remove unneeded MODULE_VERSION() usage | From | "Enrico Weigelt, metux IT consult" <> | Date | Tue, 8 Dec 2020 08:48:56 +0100 |
| |
On 05.12.20 08:06, Sven Eckelmann wrote:
Hi,
> Is there some explanation besides an opinion? Some kind goal which you want to > achieve with it maybe?
Just a cleanup. I've been under the impression that this version is just an relic from oot times.
> At least for us it was an easy way to query the release cycle information via > batctl. Which made it easier for us to roughly figure out what an reporter/ > inquirer was using - independent of whether he is using the in-kernel version > or a backported version.
Is the OOT scenario still valid ?
> Loosing this source of information and breaking parts of batctl and other > tools (respondd, ...) is not the end of the world. But I would at least know > why this is now necessary.
Okay, if this particular information indeed has a practical value, we should keep it. Taking it as a NAK.
Perhaps we should add a comment what it's used for and make sure, the version number is properly maintained.
The problem I see w/ those version fields is that we have lots of changes in the kernel tree, w/o the version number being increased - making this information at least doubtful.
--mtx
-- --- Hinweis: unverschlüsselte E-Mails können leicht abgehört und manipuliert werden ! Für eine vertrauliche Kommunikation senden Sie bitte ihren GPG/PGP-Schlüssel zu. --- Enrico Weigelt, metux IT consult Free software and Linux embedded engineering info@metux.net -- +49-151-27565287
| |