Messages in this thread | | | Subject | Re: [PATCH v1 1/3] scsi: ufs: Distinguish between query REQ and query RSP in query trace | From | Bean Huo <> | Date | Tue, 08 Dec 2020 22:30:28 +0100 |
| |
On Mon, 2020-12-07 at 10:21 -0500, Steven Rostedt wrote: > > @@ -321,9 +321,15 @@ static void ufshcd_add_cmd_upiu_trace(struct > > ufs_hba *hba, unsigned int tag, > > static void ufshcd_add_query_upiu_trace(struct ufs_hba *hba, > > unsigned int tag, > > const char *str) > > { > > - struct utp_upiu_req *rq = hba->lrb[tag].ucd_req_ptr; > > + struct utp_upiu_req *rq_rsp; > > + > > I would add: > > if (!trace_ufshcd_upiu_enabled()) > return; > > Why do the work if the trace point is not enabled? > > -- Steve
Steve,
Thanks a lot, I will fix it in the next version.
Thanks, Bean
| |