lkml.org 
[lkml]   [2020]   [Dec]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 27/32] dt-bindings: net: correct interrupt flags in examples
    Date
    From: Krzysztof Kozlowski <krzk@kernel.org>

    [ Upstream commit 4d521943f76bd0d1e68ea5e02df7aadd30b2838a ]

    GPIO_ACTIVE_x flags are not correct in the context of interrupt flags.
    These are simple defines so they could be used in DTS but they will not
    have the same meaning:
    1. GPIO_ACTIVE_HIGH = 0 = IRQ_TYPE_NONE
    2. GPIO_ACTIVE_LOW = 1 = IRQ_TYPE_EDGE_RISING

    Correct the interrupt flags, assuming the author of the code wanted same
    logical behavior behind the name "ACTIVE_xxx", this is:
    ACTIVE_LOW => IRQ_TYPE_LEVEL_LOW
    ACTIVE_HIGH => IRQ_TYPE_LEVEL_HIGH

    Fixes: a1a8b4594f8d ("NFC: pn544: i2c: Add DTS Documentation")
    Fixes: 6be88670fc59 ("NFC: nxp-nci_i2c: Add I2C support to NXP NCI driver")
    Fixes: e3b329221567 ("dt-bindings: can: tcan4x5x: Update binding to use interrupt property")
    Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
    Acked-by: Rob Herring <robh@kernel.org>
    Acked-by: Marc Kleine-Budde <mkl@pengutronix.de> # for tcan4x5x.txt
    Link: https://lore.kernel.org/r/20201026153620.89268-1-krzk@kernel.org
    Signed-off-by: Jakub Kicinski <kuba@kernel.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    Documentation/devicetree/bindings/net/nfc/nxp-nci.txt | 2 +-
    Documentation/devicetree/bindings/net/nfc/pn544.txt | 2 +-
    2 files changed, 2 insertions(+), 2 deletions(-)

    --- a/Documentation/devicetree/bindings/net/nfc/nxp-nci.txt
    +++ b/Documentation/devicetree/bindings/net/nfc/nxp-nci.txt
    @@ -25,7 +25,7 @@ Example (for ARM-based BeagleBone with N
    clock-frequency = <100000>;

    interrupt-parent = <&gpio1>;
    - interrupts = <29 GPIO_ACTIVE_HIGH>;
    + interrupts = <29 IRQ_TYPE_LEVEL_HIGH>;

    enable-gpios = <&gpio0 30 GPIO_ACTIVE_HIGH>;
    firmware-gpios = <&gpio0 31 GPIO_ACTIVE_HIGH>;
    --- a/Documentation/devicetree/bindings/net/nfc/pn544.txt
    +++ b/Documentation/devicetree/bindings/net/nfc/pn544.txt
    @@ -25,7 +25,7 @@ Example (for ARM-based BeagleBone with P
    clock-frequency = <400000>;

    interrupt-parent = <&gpio1>;
    - interrupts = <17 GPIO_ACTIVE_HIGH>;
    + interrupts = <17 IRQ_TYPE_LEVEL_HIGH>;

    enable-gpios = <&gpio3 21 GPIO_ACTIVE_HIGH>;
    firmware-gpios = <&gpio3 19 GPIO_ACTIVE_HIGH>;

    \
     
     \ /
      Last update: 2020-12-06 13:09    [W:3.343 / U:1.412 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site