lkml.org 
[lkml]   [2020]   [Dec]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 28/39] chelsio/chtls: fix a double free in chtls_setkey()
    Date
    From: Dan Carpenter <dan.carpenter@oracle.com>

    [ Upstream commit 391119fb5c5c4bdb4d57c7ffeb5e8d18560783d1 ]

    The "skb" is freed by the transmit code in cxgb4_ofld_send() and we
    shouldn't use it again. But in the current code, if we hit an error
    later on in the function then the clean up code will call kfree_skb(skb)
    and so it causes a double free.

    Set the "skb" to NULL and that makes the kfree_skb() a no-op.

    Fixes: d25f2f71f653 ("crypto: chtls - Program the TLS session Key")
    Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
    Link: https://lore.kernel.org/r/X8ilb6PtBRLWiSHp@mwanda
    Signed-off-by: Jakub Kicinski <kuba@kernel.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/crypto/chelsio/chtls/chtls_hw.c | 1 +
    1 file changed, 1 insertion(+)

    --- a/drivers/crypto/chelsio/chtls/chtls_hw.c
    +++ b/drivers/crypto/chelsio/chtls/chtls_hw.c
    @@ -365,6 +365,7 @@ int chtls_setkey(struct chtls_sock *csk,
    csk->wr_unacked += DIV_ROUND_UP(len, 16);
    enqueue_wr(csk, skb);
    cxgb4_ofld_send(csk->egress_dev, skb);
    + skb = NULL;

    chtls_set_scmd(csk);
    /* Clear quiesce for Rx key */

    \
     
     \ /
      Last update: 2020-12-06 12:47    [W:2.086 / U:0.140 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site