Messages in this thread | | | Date | Thu, 03 Dec 2020 16:38:24 +0000 | From | Paul Cercueil <> | Subject | Re: [PATCH] ASoC: jz4740-i2s: add missed checks for clk_get() |
| |
Hi,
Le jeu. 3 déc. 2020 à 22:42, Chuhong Yuan <hslester96@gmail.com> a écrit : > jz4740_i2s_set_sysclk() does not check the return values of clk_get(), > while the file dereferences the pointers in clk_put(). > Add the missed checks to fix it. > > Fixes: 11bd3dd1b7c2 ("ASoC: Add JZ4740 ASoC support") > Signed-off-by: Chuhong Yuan <hslester96@gmail.com>
Acked-by: Paul Cercueil <paul@crapouillou.net>
Cheers, -Paul
> --- > sound/soc/jz4740/jz4740-i2s.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/sound/soc/jz4740/jz4740-i2s.c > b/sound/soc/jz4740/jz4740-i2s.c > index c7bd20104b20..0793e284d0e7 100644 > --- a/sound/soc/jz4740/jz4740-i2s.c > +++ b/sound/soc/jz4740/jz4740-i2s.c > @@ -312,10 +312,14 @@ static int jz4740_i2s_set_sysclk(struct > snd_soc_dai *dai, int clk_id, > switch (clk_id) { > case JZ4740_I2S_CLKSRC_EXT: > parent = clk_get(NULL, "ext"); > + if (IS_ERR(parent)) > + return PTR_ERR(parent); > clk_set_parent(i2s->clk_i2s, parent); > break; > case JZ4740_I2S_CLKSRC_PLL: > parent = clk_get(NULL, "pll half"); > + if (IS_ERR(parent)) > + return PTR_ERR(parent); > clk_set_parent(i2s->clk_i2s, parent); > ret = clk_set_rate(i2s->clk_i2s, freq); > break; > -- > 2.26.2 >
| |