lkml.org 
[lkml]   [2020]   [Dec]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: [PATCH bpf-next] tools/resolve_btfids: Fix some error messages
On Thu, Dec 03, 2020 at 10:22:34AM +0000, Brendan Jackman wrote:
> Add missing newlines and fix polarity of strerror argument.
>
> Signed-off-by: Brendan Jackman <jackmanb@google.com>

Acked-by: Jiri Olsa <jolsa@redhat.com>

thanks,
jirka

> ---
> tools/bpf/resolve_btfids/main.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/tools/bpf/resolve_btfids/main.c b/tools/bpf/resolve_btfids/main.c
> index dfa540d8a02d..e3ea569ee125 100644
> --- a/tools/bpf/resolve_btfids/main.c
> +++ b/tools/bpf/resolve_btfids/main.c
> @@ -454,7 +454,7 @@ static int symbols_collect(struct object *obj)
> return -ENOMEM;
>
> if (id->addr_cnt >= ADDR_CNT) {
> - pr_err("FAILED symbol %s crossed the number of allowed lists",
> + pr_err("FAILED symbol %s crossed the number of allowed lists\n",
> id->name);
> return -1;
> }
> @@ -477,8 +477,8 @@ static int symbols_resolve(struct object *obj)
> btf = btf__parse(obj->btf ?: obj->path, NULL);
> err = libbpf_get_error(btf);
> if (err) {
> - pr_err("FAILED: load BTF from %s: %s",
> - obj->path, strerror(err));
> + pr_err("FAILED: load BTF from %s: %s\n",
> + obj->path, strerror(-err));
> return -1;
> }
>
>
> base-commit: 97306be45fbe7a02461c3c2a57e666cf662b1aaf
> --
> 2.29.2.454.gaff20da3a2-goog
>

\
 
 \ /
  Last update: 2020-12-03 16:13    [W:0.041 / U:0.044 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site