Messages in this thread | ![/](/images/icornerl.gif) | | Date | Thu, 3 Dec 2020 14:43:56 +0000 | From | Mark Brown <> | Subject | Re: [PATCH] ASoC: amd: add missed checks for clk_get() |
| |
On Thu, Dec 03, 2020 at 10:31:16PM +0800, Chuhong Yuan wrote:
> da7219_dai_wclk = clk_get(component->dev, "da7219-dai-wclk"); > + if (IS_ERR(da7219_dai_wclk)) > + return PTR_ERR(da7219_dai_wclk); > + > da7219_dai_bclk = clk_get(component->dev, "da7219-dai-bclk"); > + if (IS_ERR(da7219_dai_bclk)) > + return PTR_ERR(da7219_dai_bclk);
This is also buggy - instead of ignoring the errors (which is an issue) we now leak the wclk if the bclk fails. Probably should convert to devm as well. [unhandled content-type:application/pgp-signature] | ![\](/images/icornerr.gif) |