Messages in this thread | | | From | Lukas Bulwahn <> | Date | Thu, 3 Dec 2020 15:40:12 +0100 | Subject | Re: [PATCH] netfilter: conntrack: fix -Wformat |
| |
On Thu, Dec 3, 2020 at 2:44 PM Miguel Ojeda <miguel.ojeda.sandonis@gmail.com> wrote: > > On Thu, Dec 3, 2020 at 8:26 AM Lukas Bulwahn <lukas.bulwahn@gmail.com> wrote: > > > > It is not a competition between checkpatch and clang-format, but if it would be: > > Please note that clang-tidy is a different tool, it is designed to > write lints based on the AST rather than formatting. > > > But jokes aside: Dwaipayan Ray, a mentee Joe and I are working with, > > has already submitted a patch to checkpatch that identifies those > > patterns and provides a fix: > > > > https://lore.kernel.org/lkml/20201128200046.78739-1-dwaipayanray1@gmail.com/ > > That is very good! However, it does not hurt to have it repeated in > clang-tidy too: it is a very good thing to have a full C parser behind > when writing lints! >
Completely agree. A regular expression is only a limited (but quite powerful) heuristics to a full C parser :)
... and it did a good job in the case here.
Lukas
> Cheers, > Miguel
| |