lkml.org 
[lkml]   [2020]   [Dec]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v4 2/3] spi: Add SPI_NO_TX/RX support
On Thu, Dec 3, 2020 at 4:10 PM Andy Shevchenko
<andy.shevchenko@gmail.com> wrote:
> On Thu, Dec 3, 2020 at 4:00 PM Alexandru Ardelean
> <alexandru.ardelean@analog.com> wrote:

> > +#define SPI_NO_TX BIT(31) /* no transmit wire */
> > +#define SPI_NO_RX BIT(30) /* no receive wire */
> > +#define SPI_MODE_KERNEL_MASK (SPI_NO_TX | SPI_NO_RX)
>
> This needs a comment to explain what's going on with the flags (split).

...and to be consistent with proposal in uAPI:

#define SPI_MODE_KERNEL_MASK (~(BIT(30) - 1))

--
With Best Regards,
Andy Shevchenko

\
 
 \ /
  Last update: 2020-12-03 15:28    [W:0.056 / U:0.268 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site