Messages in this thread | | | Date | Thu, 03 Dec 2020 13:46:14 +0000 | From | Marc Zyngier <> | Subject | Re: [PATCH v4 16/26] kvm: arm64: Bootstrap PSCI SMC handler in nVHE EL2 |
| |
A couple of cosmetic comments below, none of which require immediate addressing.
[...]
> diff --git a/arch/arm64/kvm/hyp/nvhe/psci-relay.c > b/arch/arm64/kvm/hyp/nvhe/psci-relay.c > new file mode 100644 > index 000000000000..61375d4571c2 > --- /dev/null > +++ b/arch/arm64/kvm/hyp/nvhe/psci-relay.c > @@ -0,0 +1,100 @@ > +// SPDX-License-Identifier: GPL-2.0-only > +/* > + * Copyright (C) 2020 - Google LLC > + * Author: David Brazdil <dbrazdil@google.com> > + */ > + > +#include <asm/kvm_asm.h> > +#include <asm/kvm_hyp.h> > +#include <asm/kvm_mmu.h> > +#include <kvm/arm_hypercalls.h> > +#include <linux/arm-smccc.h> > +#include <linux/psci.h> > +#include <kvm/arm_psci.h>
nit: is there an ordering issue that requires this to be out of order?
> +#include <uapi/linux/psci.h> > + > +#include <nvhe/trap_handler.h> > + > +/* Config options set by the host. */ > +__ro_after_init u32 kvm_host_psci_version; > +__ro_after_init struct psci_0_1_function_ids > kvm_host_psci_0_1_function_ids;
nit: we usually place attributes after the type.
Thanks,
M. -- Jazz is not dead. It just smells funny...
| |