Messages in this thread | | | Date | Thu, 3 Dec 2020 13:41:21 +0100 | From | Borislav Petkov <> | Subject | Re: [PATCH v2 1/3] x86/uprobes: Fix not using prefixes.nbytes for loop over prefixes.bytes |
| |
On Thu, Dec 03, 2020 at 01:37:57PM +0100, Borislav Petkov wrote: > Btw, looking at the struct insn definition, that prefixes member should > have a comment above it that those are the legacy prefixes which can be > <= 4. But that's minor.
And that naked 4 is poking my eye too - It'd be better if it were NUM_LEGACY_PREFIXES.
-- Regards/Gruss, Boris.
https://people.kernel.org/tglx/notes-about-netiquette
| |