Messages in this thread | | | Subject | Re: [PATCH -mmots] checkpatch: add fix for non-standard signature - co-authored-by | From | Aditya <> | Date | Thu, 3 Dec 2020 17:53:43 +0530 |
| |
On 3/12/20 4:29 pm, Lukas Bulwahn wrote: > On Thu, Dec 3, 2020 at 10:59 AM Aditya <yashsri421@gmail.com> wrote: >> >> On 3/12/20 12:26 am, Joe Perches wrote: >>> On Thu, 2020-12-03 at 00:00 +0530, Aditya Srivastava wrote: >>>> Currently, checkpatch.pl warns us for BAD_SIGN_OFF on the usage of >>>> non-standard signatures. >>>> >>>> An evaluation on v4.13..v5.8 showed that out of 539 warnings due to >>>> non-standard signatures, 43 are due to the use of 'Co-authored-by' >>>> tag, which may seem correct, but is not standard. >>>> >>>> The standard signature equivalent for 'Co-authored-by' is >>>> 'Co-developed-by'. >>> >>> I'm not going to ack this as I don't mind non-standard signatures. >>> >> >> What do you suggest? >> Should I drop this patch and move on? >> > > Joe does not ack this, but he also does not nack it. > > You either move on (which is perfectly fine), or > > you either wait that Andrew Morton reviews it and accepts it because > he thinks it useful, or > > you reach out to the git committers that have been using > Co-authored-by in the past and ask them if this kind of feature would > have been helpful for them and you get an ack from them that convinces > Andrew Morton to pick this. > > I hope this helps. If nobody thinks it is a useful feature, move on to > work others acknowledge as useful. We have enough stuff to work on. >
Okay. I get it now. Thanks a lot Lukas :)
-- Aditya
> Lukas >
| |