Messages in this thread | | | Subject | Re: [v2] i2c: mediatek: Move suspend and resume handling to NOIRQ phase | From | Grygorii Strashko <> | Date | Thu, 3 Dec 2020 10:01:10 +0200 |
| |
On 03/12/2020 03:25, Qii Wang wrote: > On Wed, 2020-12-02 at 16:35 +0100, Wolfram Sang wrote: >> Hi, >> >>> Some i2c device driver indirectly uses I2C driver when it is now >>> being suspended. The i2c devices driver is suspended during the >>> NOIRQ phase and this cannot be changed due to other dependencies. >>> Therefore, we also need to move the suspend handling for the I2C >>> controller driver to the NOIRQ phase as well. >>> >>> Signed-off-by: Qii Wang <qii.wang@mediatek.com> >> >> Is this a bugfix and should go into 5.10? Or can it wait for 5.11? >> > > Yes, Can you help to apply it into 5.10? Thanks
To be honest if you still do have any i2c device which accessing i2c buss after _noirq stage and your driver does not implement .master_xfer_atomic() - you definitely have a bigger problem. So adding IRQF_NO_SUSPEND sound like a hack and probably works just by luck.
-- Best regards, grygorii
| |