Messages in this thread | | | Date | Thu, 3 Dec 2020 17:06:28 -0800 | From | Jakub Kicinski <> | Subject | Re: [PATCH net-next 1/4] ptp: clockmatrix: reset device and check BOOT_STATUS |
| |
On Thu, 3 Dec 2020 10:20:16 -0500 min.li.xe@renesas.com wrote: > From: Min Li <min.li.xe@renesas.com> > > SM_RESET device only when loading full configuration and check > for BOOT_STATUS. Also remove polling for write trigger done in > _idtcm_settime(). > > Signed-off-by: Min Li <min.li.xe@renesas.com>
Please fix the checkpatch warnings:
CHECK: Unnecessary parentheses around 'regaddr < GPIO_USER_CONTROL' #62: FILE: drivers/ptp/ptp_clockmatrix.c:60: + if ((regaddr < GPIO_USER_CONTROL) + || (regaddr >= SCRATCH))
CHECK: Unnecessary parentheses around 'regaddr >= SCRATCH' #62: FILE: drivers/ptp/ptp_clockmatrix.c:60: + if ((regaddr < GPIO_USER_CONTROL) + || (regaddr >= SCRATCH))
CHECK: Logical continuations should be on the previous line #63: FILE: drivers/ptp/ptp_clockmatrix.c:61: + if ((regaddr < GPIO_USER_CONTROL) + || (regaddr >= SCRATCH))
CHECK: Unnecessary parentheses around 'loaddr > 0x7b' #67: FILE: drivers/ptp/ptp_clockmatrix.c:65: + if (((loaddr > 0x7b) && (loaddr <= 0x7f)) + || loaddr > 0xfb)
CHECK: Unnecessary parentheses around 'loaddr <= 0x7f' #67: FILE: drivers/ptp/ptp_clockmatrix.c:65: + if (((loaddr > 0x7b) && (loaddr <= 0x7f)) + || loaddr > 0xfb)
CHECK: Logical continuations should be on the previous line #68: FILE: drivers/ptp/ptp_clockmatrix.c:66: + if (((loaddr > 0x7b) && (loaddr <= 0x7f)) + || loaddr > 0xfb)
| |