Messages in this thread | | | Subject | Re: [PATCH] coresight: remove broken __exit annotations | From | Stephen Boyd <> | Date | Thu, 03 Dec 2020 16:04:52 -0800 |
| |
Quoting Arnd Bergmann (2020-12-03 15:11:40) > From: Arnd Bergmann <arnd@arndb.de> > > Functions that are annotated __exit are discarded for built-in drivers, > but the .remove callback in a device driver must still be kept around > to allow bind/unbind operations. > > There is now a linker warning for the discarded symbol references: > > `tmc_remove' referenced in section `.data' of drivers/hwtracing/coresight/coresight-tmc-core.o: defined in discarded section `.exit.text' of drivers/hwtracing/coresight/coresight-tmc-core.o > `tpiu_remove' referenced in section `.data' of drivers/hwtracing/coresight/coresight-tpiu.o: defined in discarded section `.exit.text' of drivers/hwtracing/coresight/coresight-tpiu.o > `etb_remove' referenced in section `.data' of drivers/hwtracing/coresight/coresight-etb10.o: defined in discarded section `.exit.text' of drivers/hwtracing/coresight/coresight-etb10.o > `static_funnel_remove' referenced in section `.data' of drivers/hwtracing/coresight/coresight-funnel.o: defined in discarded section `.exit.text' of drivers/hwtracing/coresight/coresight-funnel.o > `dynamic_funnel_remove' referenced in section `.data' of drivers/hwtracing/coresight/coresight-funnel.o: defined in discarded section `.exit.text' of drivers/hwtracing/coresight/coresight-funnel.o > `static_replicator_remove' referenced in section `.data' of drivers/hwtracing/coresight/coresight-replicator.o: defined in discarded section `.exit.text' of drivers/hwtracing/coresight/coresight-replicator.o > `dynamic_replicator_remove' referenced in section `.data' of drivers/hwtracing/coresight/coresight-replicator.o: defined in discarded section `.exit.text' of drivers/hwtracing/coresight/coresight-replicator.o > `catu_remove' referenced in section `.data' of drivers/hwtracing/coresight/coresight-catu.o: defined in discarded section `.exit.text' of drivers/hwtracing/coresight/coresight-catu.o > > Remove all those annotations. > > Fixes: 8b0cf82677d1 ("coresight: stm: Allow to build coresight-stm as a module") > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > ---
Reviewed-by: Stephen Boyd <swboyd@chromium.org>
| |