lkml.org 
[lkml]   [2020]   [Dec]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] scripts: kernel-doc: fix parsing function-like typedefs
On Wed,  2 Dec 2020 09:17:32 +0100
Mauro Carvalho Chehab <mchehab+huawei@kernel.org> wrote:

> Changeset 6b80975c6308 ("scripts: kernel-doc: fix typedef parsing")
> added support for things like:
>
> typedef unsigned long foo();
>
> However, it caused a regression on this prototype:
>
> typedef bool v4l2_check_dv_timings_fnc(const struct v4l2_dv_timings *t, void *handle);
>
> This is only noticed after adding a patch that checks if the
> kernel-doc identifier matches the typedef:
>
> ./scripts/kernel-doc -none $(git grep '^.. kernel-doc::' Documentation/ |cut -d ' ' -f 3|sort|uniq) 2>&1|grep expecting
> include/media/v4l2-dv-timings.h:38: warning: expecting prototype for typedef v4l2_check_dv_timings_fnc. Prototype was for typedef nc instead
>
> The problem is that, with the new parsing logic, it is not
> checking for complete words at the type part.
>
> Fix it by adding a \b at the end of each type word at the
> regex.
>
> fixes: 6b80975c6308 ("scripts: kernel-doc: fix typedef parsing")
> Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>

Applied, thanks.

jon

\
 
 \ /
  Last update: 2020-12-04 00:11    [W:0.032 / U:1.080 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site