Messages in this thread | | | Date | Thu, 03 Dec 2020 23:35:02 +0100 | From | Michael Walle <> | Subject | Re: [PATCH] drivers: gpio: add virtio-gpio guest driver |
| |
Am 2020-12-03 20:00, schrieb Enrico Weigelt, metux IT consult: > On 02.12.20 15:15, Bartosz Golaszewski wrote: >>> + bufwalk = name_buffer; >>> + >>> + while (idx < priv->num_gpios && >>> + bufwalk < (name_buffer+cf.names_size)) { >>> + gpio_names[idx] = (strlen(bufwalk) ? bufwalk >>> : NULL); >>> + bufwalk += strlen(bufwalk)+1; >>> + idx++; >> >> >> Something's wrong with indentation here. > > i dont think so: the "bufwalk ..." line belongs to the while expression > and is right under the "idx", as it should be. I didn't want to break > up > at the "<" operator. shall i do this instead ?
Or don't break the lines at all. Both lines don't add up to more than 100 chars, right?
-michael
| |