lkml.org 
[lkml]   [2020]   [Dec]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2 -next] staging: greybus: light: Use kzalloc for allocating only one thing
From
Date
On 12/29/20 7:37 PM, Zheng Yongjun wrote:
> Use kzalloc rather than kcalloc(1,...)
>
> The semantic patch that makes this change is as follows:
> (http://coccinelle.lip6.fr/)
>
> // <smpl>
> @@
> @@
>
> - kcalloc(1,
> + kzalloc(
> ...)
> // </smpl>
>
> Signed-off-by: Zheng Yongjun <zhengyongjun3@huawei.com>

Looks good.

Reviewed-by: Alex Elder <elder@linaro.org>

> ---
> drivers/staging/greybus/light.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/staging/greybus/light.c b/drivers/staging/greybus/light.c
> index d2672b65c3f4..87d36948c610 100644
> --- a/drivers/staging/greybus/light.c
> +++ b/drivers/staging/greybus/light.c
> @@ -290,8 +290,7 @@ static int channel_attr_groups_set(struct gb_channel *channel,
> channel->attrs = kcalloc(size + 1, sizeof(*channel->attrs), GFP_KERNEL);
> if (!channel->attrs)
> return -ENOMEM;
> - channel->attr_group = kcalloc(1, sizeof(*channel->attr_group),
> - GFP_KERNEL);
> + channel->attr_group = kzalloc(sizeof(*channel->attr_group), GFP_KERNEL);
> if (!channel->attr_group)
> return -ENOMEM;
> channel->attr_groups = kcalloc(2, sizeof(*channel->attr_groups),
>

\
 
 \ /
  Last update: 2020-12-30 04:35    [W:0.031 / U:0.880 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site