Messages in this thread | | | Subject | Re: [PATCH 01/14] mfd: arizona: Add jack pointer to struct arizona | From | Richard Fitzgerald <> | Date | Tue, 29 Dec 2020 16:51:57 +0000 |
| |
On 29/12/2020 15:40, Hans de Goede wrote: > Hi, > > On 12/29/20 4:15 PM, Mark Brown wrote: >> On Tue, Dec 29, 2020 at 03:06:35PM +0000, Charles Keepax wrote: >> >>> There is maybe more argument for porting the Arizona code across >>> anyways, since for a long time Android didn't properly support extcon >>> either. It supported the earlier out of tree switch stuff, extcon >> >> Completely moving the driver doesn't cause the same problems as the >> current proposal (unless it drops functionality I guess, there were >> issues with adding new detection types into the input layer but I can't >> remember if this hardware was impacted by that or not). > > The input-layer supports the following switches: > > SW_HEADPHONE_INSERT > SW_MICROPHONE_INSERT > SW_LINEOUT_INSERT > SW_JACK_PHYSICAL_INSERT > > Which is a 1:1 mapping with the cable-types currently exported by > extcon-arizona.c . > > I'm fine with fully moving extcon-arizona.c over to only using > sound/core/jack.c functionality and it no longer exporting an > extcon device. > > I guess we should move it out of drivers/extcon then though. > I suggest using: sound/soc/cirrus/arizona-jack-detect.c > Note that sound/soc/cirrus is a new dir here. Would that work > for you ?
Shouldn't it be sound/soc/codecs/arizona-jack.c so that it is with all the other code for those codecs? > > And I guess we probably also want to change the MFD instantiated > platform-dev's name to which it binds then? > > I suggest using: "arizona-jack-detect" as new pdev name. > > It will take me some time before I can make time to implement this, > but this is a plan which I can get behind. > > Regards, > > Hans >
| |