Messages in this thread | ![/](/images/icornerl.gif) | | Subject | Re: [PATCH net-next] net/mlx5: Use kzalloc for allocating only one thing | From | Joe Perches <> | Date | Tue, 29 Dec 2020 08:17:58 -0800 |
| |
On Tue, 2020-12-29 at 21:53 +0800, Zheng Yongjun wrote: > Use kzalloc rather than kcalloc(1,...) [] > diff --git a/drivers/net/ethernet/mellanox/mlx5/core/steering/dr_action.c b/drivers/net/ethernet/mellanox/mlx5/core/steering/dr_action.c [] > @@ -1782,7 +1782,7 @@ static int dr_action_create_modify_action(struct mlx5dr_domain *dmn, > if (!chunk) > return -ENOMEM; > > > - hw_actions = kcalloc(1, max_hw_actions * DR_MODIFY_ACTION_SIZE, GFP_KERNEL); > + hw_actions = kzalloc(max_hw_actions * DR_MODIFY_ACTION_SIZE, GFP_KERNEL);
Perhaps instead:
hw_actions = kcalloc(max_hw_actions, DR_MODIFY_ACTION_SIZE, GFP_KERNEL);
| ![\](/images/icornerr.gif) |