lkml.org 
[lkml]   [2020]   [Dec]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 490/717] virtio_net: Fix error code in probe()
    Date
    From: Dan Carpenter <dan.carpenter@oracle.com>

    [ Upstream commit 411ea23a76526e6efed0b601abb603d3c981b333 ]

    Set a negative error code intead of returning success if the MTU has
    been changed to something invalid.

    Fixes: fe36cbe0671e ("virtio_net: clear MTU when out of range")
    Reported-by: Robert Buhren <robert.buhren@sect.tu-berlin.de>
    Reported-by: Felicitas Hetzelt <file@sect.tu-berlin.de>
    Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
    Link: https://lore.kernel.org/r/X8pGVJSeeCdII1Ys@mwanda
    Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
    Acked-by: Jason Wang <jasowang@redhat.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/net/virtio_net.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
    index 21b71148c5324..34bb95dd92392 100644
    --- a/drivers/net/virtio_net.c
    +++ b/drivers/net/virtio_net.c
    @@ -3072,6 +3072,7 @@ static int virtnet_probe(struct virtio_device *vdev)
    dev_err(&vdev->dev,
    "device MTU appears to have changed it is now %d < %d",
    mtu, dev->min_mtu);
    + err = -EINVAL;
    goto free;
    }

    --
    2.27.0


    \
     
     \ /
      Last update: 2020-12-28 15:24    [W:2.702 / U:1.128 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site