lkml.org 
[lkml]   [2020]   [Dec]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 416/717] mac80211: fix a mistake check for rx_stats update
    Date
    From: Wen Gong <wgong@codeaurora.org>

    [ Upstream commit f879ac8ed6c83ce05fcb53815a8ea83c5b6099a1 ]

    It should be !is_multicast_ether_addr() in ieee80211_rx_h_sta_process()
    for the rx_stats update, below commit remove the !, this patch is to
    change it back.

    It lead the rx rate "iw wlan0 station dump" become invalid for some
    scenario when IEEE80211_HW_USES_RSS is set.

    Fixes: 09a740ce352e ("mac80211: receive and process S1G beacons")
    Signed-off-by: Wen Gong <wgong@codeaurora.org>
    Link: https://lore.kernel.org/r/1607483189-3891-1-git-send-email-wgong@codeaurora.org
    Signed-off-by: Johannes Berg <johannes.berg@intel.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    net/mac80211/rx.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/net/mac80211/rx.c b/net/mac80211/rx.c
    index 1e2e5a406d587..2a5a11f92b03e 100644
    --- a/net/mac80211/rx.c
    +++ b/net/mac80211/rx.c
    @@ -1758,7 +1758,7 @@ ieee80211_rx_h_sta_process(struct ieee80211_rx_data *rx)
    } else if (rx->sdata->vif.type == NL80211_IFTYPE_OCB) {
    sta->rx_stats.last_rx = jiffies;
    } else if (!ieee80211_is_s1g_beacon(hdr->frame_control) &&
    - is_multicast_ether_addr(hdr->addr1)) {
    + !is_multicast_ether_addr(hdr->addr1)) {
    /*
    * Mesh beacons will update last_rx when if they are found to
    * match the current local configuration when processed.
    --
    2.27.0


    \
     
     \ /
      Last update: 2020-12-28 15:24    [W:4.047 / U:0.076 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site