lkml.org 
[lkml]   [2020]   [Dec]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 275/717] hwmon: (ina3221) Fix PM usage counter unbalance in ina3221_write_enable
    Date
    From: Zhang Qilong <zhangqilong3@huawei.com>

    [ Upstream commit bce776f10069c806290eaac712ba73432ae8ecd7 ]

    pm_runtime_get_sync will increment pm usage counter
    even it failed. Forgetting to putting operation will
    result in reference leak here. We fix it by replacing
    it with pm_runtime_resume_and_get to keep usage counter
    balanced. It depends on the mainline commit[PM: runtime:
    Add pm_runtime_resume_and_get to deal with usagecounter].

    Fixes: 323aeb0eb5d9a ("hwmon: (ina3221) Add PM runtime support")
    Signed-off-by: Zhang Qilong <zhangqilong3@huawei.com>
    Link: https://lore.kernel.org/r/20201202145320.1135614-1-zhangqilong3@huawei.com
    Signed-off-by: Guenter Roeck <linux@roeck-us.net>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/hwmon/ina3221.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/hwmon/ina3221.c b/drivers/hwmon/ina3221.c
    index 41fb17e0d6416..ad11cbddc3a7b 100644
    --- a/drivers/hwmon/ina3221.c
    +++ b/drivers/hwmon/ina3221.c
    @@ -489,7 +489,7 @@ static int ina3221_write_enable(struct device *dev, int channel, bool enable)

    /* For enabling routine, increase refcount and resume() at first */
    if (enable) {
    - ret = pm_runtime_get_sync(ina->pm_dev);
    + ret = pm_runtime_resume_and_get(ina->pm_dev);
    if (ret < 0) {
    dev_err(dev, "Failed to get PM runtime\n");
    return ret;
    --
    2.27.0


    \
     
     \ /
      Last update: 2020-12-28 15:15    [W:3.595 / U:0.048 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site