lkml.org 
[lkml]   [2020]   [Dec]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 408/453] spi: pic32: Dont leak DMA channels in probe error path
    Date
    From: Lukas Wunner <lukas@wunner.de>

    commit c575e9113bff5e024d75481613faed5ef9d465b2 upstream.

    If the calls to devm_request_irq() or devm_spi_register_master() fail
    on probe of the PIC32 SPI driver, the DMA channels requested by
    pic32_spi_dma_prep() are erroneously not released. Plug the leak.

    Fixes: 1bcb9f8ceb67 ("spi: spi-pic32: Add PIC32 SPI master driver")
    Signed-off-by: Lukas Wunner <lukas@wunner.de>
    Cc: <stable@vger.kernel.org> # v4.7+
    Cc: Purna Chandra Mandal <purna.mandal@microchip.com>
    Link: https://lore.kernel.org/r/9624250e3a7aa61274b38219a62375bac1def637.1604874488.git.lukas@wunner.de
    Signed-off-by: Mark Brown <broonie@kernel.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/spi/spi-pic32.c | 1 +
    1 file changed, 1 insertion(+)

    --- a/drivers/spi/spi-pic32.c
    +++ b/drivers/spi/spi-pic32.c
    @@ -825,6 +825,7 @@ static int pic32_spi_probe(struct platfo
    return 0;

    err_bailout:
    + pic32_spi_dma_unprep(pic32s);
    clk_disable_unprepare(pic32s->clk);
    err_master:
    spi_master_put(master);

    \
     
     \ /
      Last update: 2020-12-28 14:58    [W:4.027 / U:0.024 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site