Messages in this thread | | | Date | Mon, 28 Dec 2020 22:40:35 +0100 | From | Thomas Bogendoerfer <> | Subject | Re: [PATCH] MIPS: No need to check CPU 0 in cps_cpu_disable() |
| |
On Tue, Dec 15, 2020 at 01:07:26PM +0800, Tiezhu Yang wrote: > After commit 9cce844abf07 ("MIPS: CPU#0 is not hotpluggable"), > c->hotpluggable is 0 for CPU 0 and it will not generate a control > file in sysfs for this CPU: > > [root@linux loongson]# cat /sys/devices/system/cpu/cpu0/online > cat: /sys/devices/system/cpu/cpu0/online: No such file or directory > [root@linux loongson]# echo 0 > /sys/devices/system/cpu/cpu0/online > bash: /sys/devices/system/cpu/cpu0/online: Permission denied > > So no need to check CPU 0 in cps_cpu_disable(), just remove it. > > Reported-by: liwei (GF) <liwei391@huawei.com> > Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn> > --- > > cps_cpu_disable() is not done in the early similar patch, > sorry for that. > > arch/mips/kernel/smp-cps.c | 3 --- > 1 file changed, 3 deletions(-)
applied to mips-next.
Thomas.
-- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]
| |