lkml.org 
[lkml]   [2020]   [Dec]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.9 066/175] staging: greybus: codecs: Fix reference counter leak in error handling
    Date
    From: Zhang Qilong <zhangqilong3@huawei.com>

    [ Upstream commit 3952659a6108f77a0d062d8e8487bdbdaf52a66c ]

    gb_pm_runtime_get_sync has increased the usage counter of the device here.
    Forgetting to call gb_pm_runtime_put_noidle will result in usage counter
    leak in the error branch of (gbcodec_hw_params and gbcodec_prepare). We
    fixed it by adding it.

    Fixes: c388ae7696992 ("greybus: audio: Update pm runtime support in dai_ops callback")
    Signed-off-by: Zhang Qilong <zhangqilong3@huawei.com>
    Link: https://lore.kernel.org/r/20201109131347.1725288-2-zhangqilong3@huawei.com
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/staging/greybus/audio_codec.c | 2 ++
    1 file changed, 2 insertions(+)

    diff --git a/drivers/staging/greybus/audio_codec.c b/drivers/staging/greybus/audio_codec.c
    index 8a0744b58a329..4c2d6c2d4fb41 100644
    --- a/drivers/staging/greybus/audio_codec.c
    +++ b/drivers/staging/greybus/audio_codec.c
    @@ -491,6 +491,7 @@ static int gbcodec_hw_params(struct snd_pcm_substream *substream,
    if (ret) {
    dev_err_ratelimited(dai->dev, "%d: Error during set_config\n",
    ret);
    + gb_pm_runtime_put_noidle(bundle);
    mutex_unlock(&codec->lock);
    return ret;
    }
    @@ -562,6 +563,7 @@ static int gbcodec_prepare(struct snd_pcm_substream *substream,
    break;
    }
    if (ret) {
    + gb_pm_runtime_put_noidle(bundle);
    mutex_unlock(&codec->lock);
    dev_err_ratelimited(dai->dev, "set_data_size failed:%d\n",
    ret);
    --
    2.27.0


    \
     
     \ /
      Last update: 2020-12-28 17:39    [W:3.279 / U:0.116 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site