lkml.org 
[lkml]   [2020]   [Dec]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 160/717] mfd: htc-i2cpld: Add the missed i2c_put_adapter() in htcpld_register_chip_i2c()
    Date
    From: Jing Xiangfeng <jingxiangfeng@huawei.com>

    [ Upstream commit 9a463284706c5217872c3cadaca863d47129bd95 ]

    htcpld_register_chip_i2c() misses to call i2c_put_adapter() in an error
    path. Add the missed function call to fix it.

    Fixes: 6048a3dd2371 ("mfd: Add HTCPLD driver")
    Signed-off-by: Jing Xiangfeng <jingxiangfeng@huawei.com>
    Signed-off-by: Lee Jones <lee.jones@linaro.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/mfd/htc-i2cpld.c | 2 ++
    1 file changed, 2 insertions(+)

    diff --git a/drivers/mfd/htc-i2cpld.c b/drivers/mfd/htc-i2cpld.c
    index 247f9849e54ae..417b0355d904d 100644
    --- a/drivers/mfd/htc-i2cpld.c
    +++ b/drivers/mfd/htc-i2cpld.c
    @@ -346,6 +346,7 @@ static int htcpld_register_chip_i2c(
    if (!i2c_check_functionality(adapter, I2C_FUNC_SMBUS_READ_BYTE_DATA)) {
    dev_warn(dev, "i2c adapter %d non-functional\n",
    pdata->i2c_adapter_id);
    + i2c_put_adapter(adapter);
    return -EINVAL;
    }

    @@ -360,6 +361,7 @@ static int htcpld_register_chip_i2c(
    /* I2C device registration failed, contineu with the next */
    dev_warn(dev, "Unable to add I2C device for 0x%x\n",
    plat_chip_data->addr);
    + i2c_put_adapter(adapter);
    return PTR_ERR(client);
    }

    --
    2.27.0


    \
     
     \ /
      Last update: 2020-12-28 16:16    [W:4.305 / U:0.352 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site