lkml.org 
[lkml]   [2020]   [Dec]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 138/717] video: fbdev: atmel_lcdfb: fix return error code in atmel_lcdfb_of_init()
    Date
    From: Yang Yingliang <yangyingliang@huawei.com>

    [ Upstream commit ba236455ee750270f33998df57f982433cea4d8e ]

    If devm_kzalloc() failed after the first time, atmel_lcdfb_of_init()
    can't return -ENOMEM, fix this by putting the error code in loop.

    Fixes: b985172b328a ("video: atmel_lcdfb: add device tree suport")
    Reported-by: Hulk Robot <hulkci@huawei.com>
    Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
    Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
    Link: https://patchwork.freedesktop.org/patch/msgid/20201117061350.3453742-1-yangyingliang@huawei.com
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/video/fbdev/atmel_lcdfb.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/video/fbdev/atmel_lcdfb.c b/drivers/video/fbdev/atmel_lcdfb.c
    index 8c1d47e52b1a6..355b6120dc4f0 100644
    --- a/drivers/video/fbdev/atmel_lcdfb.c
    +++ b/drivers/video/fbdev/atmel_lcdfb.c
    @@ -987,8 +987,8 @@ static int atmel_lcdfb_of_init(struct atmel_lcdfb_info *sinfo)
    }

    INIT_LIST_HEAD(&pdata->pwr_gpios);
    - ret = -ENOMEM;
    for (i = 0; i < gpiod_count(dev, "atmel,power-control"); i++) {
    + ret = -ENOMEM;
    gpiod = devm_gpiod_get_index(dev, "atmel,power-control",
    i, GPIOD_ASIS);
    if (IS_ERR(gpiod))
    --
    2.27.0


    \
     
     \ /
      Last update: 2020-12-28 16:16    [W:4.039 / U:0.204 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site