lkml.org 
[lkml]   [2020]   [Dec]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 409/717] mtd: rawnand: meson: Fix a resource leak in init
    Date
    From: Dan Carpenter <dan.carpenter@oracle.com>

    [ Upstream commit ad8566d3555c4731e6b48823b92d3929b0394c14 ]

    Call clk_disable_unprepare(nfc->phase_rx) if the clk_set_rate() function
    fails to avoid a resource leak.

    Fixes: 8fae856c5350 ("mtd: rawnand: meson: add support for Amlogic NAND flash controller")
    Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
    Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
    Link: https://lore.kernel.org/linux-mtd/X8ikVCnUsfTpffFB@mwanda
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/mtd/nand/raw/meson_nand.c | 5 ++++-
    1 file changed, 4 insertions(+), 1 deletion(-)

    diff --git a/drivers/mtd/nand/raw/meson_nand.c b/drivers/mtd/nand/raw/meson_nand.c
    index 48e6dac96be6d..1fd7f7024c0b4 100644
    --- a/drivers/mtd/nand/raw/meson_nand.c
    +++ b/drivers/mtd/nand/raw/meson_nand.c
    @@ -1044,9 +1044,12 @@ static int meson_nfc_clk_init(struct meson_nfc *nfc)

    ret = clk_set_rate(nfc->device_clk, 24000000);
    if (ret)
    - goto err_phase_rx;
    + goto err_disable_rx;

    return 0;
    +
    +err_disable_rx:
    + clk_disable_unprepare(nfc->phase_rx);
    err_phase_rx:
    clk_disable_unprepare(nfc->phase_tx);
    err_phase_tx:
    --
    2.27.0


    \
     
     \ /
      Last update: 2020-12-28 15:52    [W:4.271 / U:1.128 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site