lkml.org 
[lkml]   [2020]   [Dec]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: regmap: debugfs: fix a memory leak when calling regmap_attach_dev
Date
> Do you mean so?
>
> commit:
> 9b947a13e7f6 ("regmap: use debugfs even when no device")

> Please take another look at known information sources.

> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=f838f8d2b694cf9d524dc4423e9dd2db13892f3f#n89
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=f838f8d2b694cf9d524dc4423e9dd2db13892f3f#n121



> Which one do you mean by "another null point"?

How do you think about to check if calls of the function “kasprintf” succeeded here?
https://elixir.bootlin.com/linux/v5.10.3/source/lib/kasprintf.c#L53

Will any more exception handling become relevant also for the implementation of the function “regmap_debugfs_init”?


-----Original Message-----
From: Markus Elfring <Markus.Elfring@web.de>
Sent: Sunday, December 27, 2020 9:40 PM
To: Wang, Xiaolei <Xiaolei.Wang@windriver.com>; kernel-janitors@vger.kernel.org
Cc: linux-kernel@vger.kernel.org; Greg Kroah-Hartman <gregkh@linuxfoundation.org>; Mark Brown <broonie@kernel.org>; Rafael J. Wysocki <rafael@kernel.org>
Subject: Re: regmap: debugfs: fix a memory leak when calling regmap_attach_dev

> Do you mean so?
>
> commit:
> 9b947a13e7f6 ("regmap: use debugfs even when no device")

> Please take another look at known information sources.

> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=f838f8d2b694cf9d524dc4423e9dd2db13892f3f#n89
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=f838f8d2b694cf9d524dc4423e9dd2db13892f3f#n121

> Which one do you mean by "another null point"?

> How do you think about to check if calls of the function “kasprintf” succeeded here?
> https://elixir.bootlin.com/linux/v5.10.3/source/lib/kasprintf.c#L53

> Will any more exception handling become relevant also for the implementation of the function “regmap_debugfs_init”?

Thanks for your suggestion, I will modify the commit log and add another null point check together with corresponding exception handling


Regards,
Xiaolei
\
 
 \ /
  Last update: 2020-12-28 03:29    [W:0.082 / U:0.648 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site