Messages in this thread | | | Subject | Re: [PATCH -V6 RESEND 2/3] NOT kernel/man-pages: man2/set_mempolicy.2: Add mode flag MPOL_F_NUMA_BALANCING | From | "Alejandro Colomar (mailing lists; readonly)" <> | Date | Wed, 2 Dec 2020 13:33:13 +0100 |
| |
Hi Huang Ying,
Please see a few fixes below.
Michael, as always, some question for you too ;)
Thanks,
Alex
On 12/2/20 9:42 AM, Huang Ying wrote: > Signed-off-by: "Huang, Ying" <ying.huang@intel.com> > --- > man2/set_mempolicy.2 | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/man2/set_mempolicy.2 b/man2/set_mempolicy.2 > index 68011eecb..3754b3e12 100644 > --- a/man2/set_mempolicy.2 > +++ b/man2/set_mempolicy.2 > @@ -113,6 +113,12 @@ A nonempty > .I nodemask > specifies node IDs that are relative to the set of > node IDs allowed by the process's current cpuset. > +.TP > +.BR MPOL_F_NUMA_BALANCING " (since Linux 5.11)"
I'd prefer it to be in alphabetical order (rather than just adding at the bottom).
That way, when lists grow, it's easier to find things.
> +Enable the Linux kernel NUMA balancing for the task if it is supported > +by kernel.
I'd s/Linux kernel/kernel/ when it doesn't specifically refer to the Linux kernel to differentiate it from other kernels. It only adds noise (IMHO). mtk?
wfix:
... supported by _the_ kernel.
> +If the flag isn't supported by Linux kernel, return -1 and errno is
wfix:
If the flag isn't supported by _the_ kernel, ...
> +set to EINVAL.
errno and EINVAL should use .I and .B respectively
> .PP > .I nodemask > points to a bit mask of node IDs that contains up to > @@ -293,6 +299,9 @@ argument specified both > .B MPOL_F_STATIC_NODES > and > .BR MPOL_F_RELATIVE_NODES . > +Or, the > +.B MPOL_F_NUMA_BALANCING > +isn't supported by the Linux kernel. > .TP > .B ENOMEM > Insufficient kernel memory was available. >
| |