Messages in this thread | | | Date | Wed, 2 Dec 2020 12:25:15 +0100 | From | Borislav Petkov <> | Subject | Re: [PATCH] EDAC, mv64x60: Fix error return code in mv64x60_pci_err_probe() |
| |
On Tue, Nov 24, 2020 at 02:30:09PM +0800, Wang ShaoBo wrote: > Fix to return -ENODEV error code when edac_pci_add_device() failed instaed > of 0 in mv64x60_pci_err_probe(), as done elsewhere in this function. > > Fixes: 4f4aeeabc061 ("drivers-edac: add marvell mv64x60 driver") > Signed-off-by: Wang ShaoBo <bobo.shaobowang@huawei.com> > --- > drivers/edac/mv64x60_edac.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/edac/mv64x60_edac.c b/drivers/edac/mv64x60_edac.c > index 3c68bb525d5d..456b9ca1fe8d 100644 > --- a/drivers/edac/mv64x60_edac.c > +++ b/drivers/edac/mv64x60_edac.c > @@ -168,6 +168,7 @@ static int mv64x60_pci_err_probe(struct platform_device *pdev) > > if (edac_pci_add_device(pci, pdata->edac_idx) > 0) { > edac_dbg(3, "failed edac_pci_add_device()\n"); > + res = -ENODEV; > goto err; > }
That driver depends on MV64X60 and I don't see anything in the tree enabling it and I can't select it AFAICT:
config MV64X60 bool select PPC_INDIRECT_PCI select CHECK_CACHE_COHERENCY
PPC folks, what do we do here?
If not used anymore, I'd love to have one less EDAC driver.
Thx.
-- Regards/Gruss, Boris.
https://people.kernel.org/tglx/notes-about-netiquette
| |