lkml.org 
[lkml]   [2020]   [Dec]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 06/18] software_node: amend software_node_unregister_node_group() to perform unregistration of array in reverse order to be consistent with software_node_unregister_nodes()
    From
    Date
    On 30/11/2020 17:47, Andy Shevchenko wrote:
    > On Mon, Nov 30, 2020 at 06:17:16PM +0200, Laurent Pinchart wrote:
    >> Hi Daniel,
    >>
    >> Thank you for the patch.
    >>
    >> The subject line is very long. We try to keep it within a 72 characters
    >> limit in the kernel. That can be a challenge sometimes, and expections
    >> can be accepted, but this one is reaaaally long.
    >>
    >> (The same comment holds for other patches in the series)
    >
    > +1.

    My bad; I'll go through the series and condense them down as much as
    possible.

    >> On Mon, Nov 30, 2020 at 01:31:17PM +0000, Daniel Scally wrote:
    >>> To maintain consistency with software_node_unregister_nodes(), reverse
    >>> the order in which the software_node_unregister_node_group() function
    >>> unregisters nodes.
    >>>
    >>> Suggested-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
    >>> Signed-off-by: Daniel Scally <djrscally@gmail.com>
    >>
    >> I"d squash this with the previous patch to avoid introducing an
    >> inconsistency.
    >
    > It's different to previous. It touches not complementary API, but different
    > one. However, I would follow your comment about documenting the behaviour of
    > these two APIs as well…

    I'll update the documentation for this function too.


    \
     
     \ /
      Last update: 2020-12-02 11:07    [W:6.074 / U:0.020 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site