Messages in this thread | | | Date | Wed, 2 Dec 2020 10:10:40 +0100 | From | Jan Kara <> | Subject | Re: [PATCH] fanotify: Fix sys_fanotify_mark() on native x86-32 |
| |
On Tue 01-12-20 16:51:26, Borislav Petkov wrote: > On Tue, Dec 01, 2020 at 10:48:10AM +0100, Jan Kara wrote: > > On Mon 30-11-20 17:30:59, Brian Gerst wrote: > > > Commit 121b32a58a3a converted native x86-32 which take 64-bit arguments to > > > use the compat handlers to allow conversion to passing args via pt_regs. > > > sys_fanotify_mark() was however missed, as it has a general compat handler. > > > Add a config option that will use the syscall wrapper that takes the split > > > args for native 32-bit. > > > > > > Reported-by: Paweł Jasiak <pawel@jasiak.xyz> > > > Fixes: 121b32a58a3a ("x86/entry/32: Use IA32-specific wrappers for syscalls taking 64-bit arguments") > > > Signed-off-by: Brian Gerst <brgerst@gmail.com> > > > > Thanks for the patch! It looks good to me. Feel free to add: > > > > Acked-by: Jan Kara <jack@suse.cz> > > > > I assume you plan to push this via x86 tree given the changes are mostly > > there, don't you? > > Looks sane to me too, I guess I can send it to Linus even now so that it > lands in 5.10. Is that what you'd prefer Jan?
Yes, that would be fine by me. Although I don't think there's a huge rush. The thing is broken for some time already so if it goes in later with CC to stable, that would also work OK.
Honza -- Jan Kara <jack@suse.com> SUSE Labs, CR
| |