Messages in this thread | | | From | Doug Anderson <> | Date | Wed, 2 Dec 2020 17:17:51 -0800 | Subject | Re: [PATCH 1/2] platform/chrome: cros_ec_spi: Don't overwrite spi::mode |
| |
Hi,
On Wed, Dec 2, 2020 at 5:16 PM Stephen Boyd <swboyd@chromium.org> wrote: > > There isn't any need to overwrite the mode here in the driver with what > has been detected by the firmware, such as DT or ACPI. In fact, if we > use the SPI CS gpio descriptor feature we will overwrite the mode with > SPI_MODE_0 where it already contains SPI_MODE_0 and more importantly > SPI_CS_HIGH. Clearing the SPI_CS_HIGH bit causes the CS line to toggle > when the device is probed when it shouldn't change, confusing the driver > and making it fail to probe. Drop the assignment and let the spi core > take care of it. > > Fixes: a17d94f0b6e1 ("mfd: Add ChromeOS EC SPI driver") > Cc: Simon Glass <sjg@chromium.org> > Cc: Gwendal Grignou <gwendal@chromium.org> > Cc: Douglas Anderson <dianders@chromium.org> > Cc: Alexandru M Stan <amstan@chromium.org> > Signed-off-by: Stephen Boyd <swboyd@chromium.org> > --- > drivers/platform/chrome/cros_ec_spi.c | 1 -
Reviewed-by: Douglas Anderson <dianders@chromium.org> Tested-by: Douglas Anderson <dianders@chromium.org>
| |