Messages in this thread | ![/](/images/icornerl.gif) | | Subject | Re: [PATCH 3/3] firmware: xilinx: Properly align function parameter | From | Michal Simek <> | Date | Wed, 2 Dec 2020 08:38:08 +0100 |
| |
On 01. 12. 20 20:42, Joe Perches wrote: > On Tue, 2020-12-01 at 16:50 +0100, Michal Simek wrote: >> Fix parameters alignment reported by checkpatch --strict. > > Please use a newer checkpatch as the 80 column warning > isn't enforced quite the same way.
I was using it but saw 80 lines breakage in editor that's why I put it there.
> >> diff --git a/include/linux/firmware/xlnx-zynqmp.h b/include/linux/firmware/xlnx-zynqmp.h > [] >> @@ -456,7 +456,8 @@ static inline int zynqmp_pm_sd_dll_reset(u32 node_id, u32 type) >> } >> >> >> static inline int zynqmp_pm_reset_assert(const enum zynqmp_pm_reset reset, >> - const enum zynqmp_pm_reset_action assert_flag) >> + const enum zynqmp_pm_reset_action >> + assert_flag) > > I think these changes aren't very good as it separates > the type from the variable name.
I have retest it and I can't see any warning when they are on the same line. Will send v2 with fixing this.
Thanks, Michal
| ![\](/images/icornerr.gif) |