lkml.org 
[lkml]   [2020]   [Dec]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH v2 0/6] kernfs: proposed locking and concurrency improvement
    From
    Date
    On Sun, 2020-12-20 at 07:52 +0800, Ian Kent wrote:
    > On Sat, 2020-12-19 at 11:23 -0500, Tejun Heo wrote:
    > > Hello,
    > >
    > > On Sat, Dec 19, 2020 at 03:08:13PM +0800, Ian Kent wrote:
    > > > And looking further I see there's a race that kernfs can't do
    > > > anything
    > > > about between kernfs_refresh_inode() and
    > > > fs/inode.c:update_times().
    > >
    > > Do kernfs files end up calling into that path tho? Doesn't look
    > > like
    > > it to
    > > me but if so yeah we'd need to override the update_time for kernfs.

    You are correct, update_time() will only be called during symlink
    following and only to update atime.

    So this isn't sufficient to update the inode attributes to reflect
    changes make by things like kernfs_setattr() or when the directory
    link count changes ...

    Sigh!

    \
     
     \ /
      Last update: 2020-12-20 02:40    [W:2.691 / U:0.024 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site