Messages in this thread | | | Subject | Re: [PATCH] staging: most: video: fixed a parentheses coding style issue. | From | Joe Perches <> | Date | Thu, 17 Dec 2020 15:58:16 -0800 |
| |
On Thu, 2020-12-17 at 15:45 -0800, Daniel West wrote: > Fixed a coding style issue.
It may pass checkpatch without warning, but it's uncommon kernel coding style.
> diff --git a/drivers/staging/most/video/video.c b/drivers/staging/most/video/video.c [] > @@ -365,8 +365,8 @@ static const struct video_device comp_videodev_template = { > > > /**************************************************************************/ > > > -static struct most_video_dev *get_comp_dev( > - struct most_interface *iface, int channel_idx) > +static struct most_video_dev *get_comp_dev > + (struct most_interface *iface, int channel_idx)
This would be better using any of:
(most common)
static struct most_video_dev *get_comp_dev(struct most_interface *iface, int channel_idx)
or (less common)
static struct most_video_dev * get_comp_dev(struct most_interface *iface, int channel_idx)
or (> 80 columns)
static struct most_video_dev *get_comp_dev(struct most_interface *iface, int channel_idx)
| |