Messages in this thread Patch in this message | ![/](/images/icornerl.gif) | | From | Douglas Anderson <> | Subject | [PATCH v3 4/4] spi: spi-geni-qcom: Print an error when we timeout setting the CS | Date | Thu, 17 Dec 2020 14:29:14 -0800 |
| |
If we're using geni to manage the chip select line (don't do it--use a GPIO!) and we happen to get a timeout waiting for the chip select command to be completed, no errors are printed even though things might not be in the best shape. Let's add a print.
Signed-off-by: Douglas Anderson <dianders@chromium.org> ---
(no changes since v2)
Changes in v2: - ("spi: spi-geni-qcom: Print an error when we timeout setting the CS") new for v2
drivers/spi/spi-geni-qcom.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/spi/spi-geni-qcom.c b/drivers/spi/spi-geni-qcom.c index b3ba092db489..5472d895a9e0 100644 --- a/drivers/spi/spi-geni-qcom.c +++ b/drivers/spi/spi-geni-qcom.c @@ -223,8 +223,10 @@ static void spi_geni_set_cs(struct spi_device *slv, bool set_flag) spin_unlock_irq(&mas->lock); time_left = wait_for_completion_timeout(&mas->cs_done, HZ); - if (!time_left) + if (!time_left) { + dev_warn(mas->dev, "Timeout setting chip select\n"); handle_fifo_timeout(spi, NULL); + } exit: pm_runtime_put(mas->dev); -- 2.29.2.684.gfbc64c5ab5-goog
| ![\](/images/icornerr.gif) |