Messages in this thread | | | Date | Thu, 17 Dec 2020 11:02:31 -0800 | From | Jakub Kicinski <> | Subject | Re: [PATCH][next] octeontx2-af: Fix undetected unmap PF error check |
| |
On Thu, 17 Dec 2020 05:24:34 +0000 George Cherian wrote: > > From: Colin Ian King <colin.king@canonical.com> > > > > Currently the check for an unmap PF error is always going to be false because > > intr_val is a 32 bit int and is being bit-mask checked against 1ULL << 32. Fix > > this by making intr_val a u64 to match the type at it is copied from, namely > > npa_event_context->npa_af_rvu_ge. > > > > Addresses-Coverity: ("Operands don't affect result") > > Fixes: f1168d1e207c ("octeontx2-af: Add devlink health reporters for NPA") > > Signed-off-by: Colin Ian King <colin.king@canonical.com> > Acked-by: George Cherian <george.cherian@marvell.com>
For some reason patchwork did not register your ack automatically. I wonder what happened. I added it manually.
Applied, thanks!
| |