Messages in this thread | | | From | Andy Shevchenko <> | Date | Thu, 17 Dec 2020 11:44:35 +0200 | Subject | Re: [net-next PATCH v2 04/14] net: phy: Introduce fwnode_get_phy_id() |
| |
On Thu, Dec 17, 2020 at 10:28 AM Calvin Johnson <calvin.johnson@oss.nxp.com> wrote: > On Tue, Dec 15, 2020 at 07:28:10PM +0200, Andy Shevchenko wrote: > > On Tue, Dec 15, 2020 at 6:44 PM Calvin Johnson > > <calvin.johnson@oss.nxp.com> wrote:
...
> > > + if (sscanf(cp, "ethernet-phy-id%4x.%4x", &upper, &lower) == 2) {
> > *phy_id = ((upper & 0xFFFF) << 16) | (lower & 0xFFFF);
> > And perhaps GENMASK() ? > > Sure. Will rewrite accordingly.
Reading this again I'm now not sure these masks are needed at all.
-- With Best Regards, Andy Shevchenko
| |