Messages in this thread | | | Date | Mon, 14 Dec 2020 23:19:48 +0800 | Subject | Re: [RFC PATCH 05/12] pinctrl: sunxi: add pinctrl driver for V831/V833 | From | Icenowy Zheng <> |
| |
于 2020年12月14日 GMT+08:00 下午10:21:18, Maxime Ripard <maxime@cerno.tech> 写到: >On Sat, Dec 12, 2020 at 12:04:23PM +0800, Icenowy Zheng wrote: >> V831/V833 are new chips from Allwinner. They're the same die with >> different package. >> >> Add a pinctrl driver for them. >> >> The difference between V831/V833 pinctrl is implemented based on the >> user manual. >> >> Cc: Linus Walleij <linus.walleij@linaro.org> >> Cc: linux-gpio@vger.kernel.org >> Signed-off-by: Icenowy Zheng <icenowy@aosc.io> >> --- >> drivers/pinctrl/sunxi/Kconfig | 5 + >> drivers/pinctrl/sunxi/Makefile | 1 + >> drivers/pinctrl/sunxi/pinctrl-sun8i-v83x.c | 743 >+++++++++++++++++++++ >> drivers/pinctrl/sunxi/pinctrl-sunxi.h | 2 + >> 4 files changed, 751 insertions(+) >> create mode 100644 drivers/pinctrl/sunxi/pinctrl-sun8i-v83x.c >> >> diff --git a/drivers/pinctrl/sunxi/Kconfig >b/drivers/pinctrl/sunxi/Kconfig >> index 593293584ecc..fc13335a3eda 100644 >> --- a/drivers/pinctrl/sunxi/Kconfig >> +++ b/drivers/pinctrl/sunxi/Kconfig >> @@ -73,6 +73,11 @@ config PINCTRL_SUN8I_V3S >> default MACH_SUN8I >> select PINCTRL_SUNXI >> >> +config PINCTRL_SUN8I_V83X >> + bool "Support for the Allwinner V831/V833 PIO" >> + default MACH_SUN8I >> + select PINCTRL_SUNXI >> + > >We're not using the wildcard much, and I'd rather be consistent with >the >name / Kconfig option scheme used for the clock driver (and the rest of >the SoCs in a similar situation)
Well, call everything V831, or call everything V833, or call things usable on V831 V831 and things only available to V833 V833?
> >Maxime
| |